chore: Add JUnit XML reporting to veneer test suites using shared require#34740
Open
quartzmo wants to merge 5 commits into
Open
chore: Add JUnit XML reporting to veneer test suites using shared require#34740quartzmo wants to merge 5 commits into
quartzmo wants to merge 5 commits into
Conversation
…uire Write minitest execution output to JUnit XML reports. This enables centralized test result indexing, flake tracing, and build health metrics reporting inside TestGrid dashboards.
quartzmo
force-pushed
the
junit-shared-helpers
branch
2 times, most recently
from
5993601 to
b78ee85
Compare
The inline rescue modifier only catches StandardError. ScriptError and its subclass LoadError must be caught explicitly to prevent the test suite from crashing when the sibling repository is not present or PR 429 has not yet been merged/released.
aandreassa
approved these changes
Jul 9, 2026
| rescue LoadError | ||
| end | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
Related to my other comment googleapis/ruby-common-tools#429 (comment).
Should we need to add minitest-reporters as a dependency so the clean-up is easier afterwards? Approving either way! LGTM
Member
Author
There was a problem hiding this comment.
Thank you for catching this, just added Gemfile updates for the veneer clients that were missing them:
fbd521923c (HEAD -> junit-shared-helpers) chore: Add minitest-reporters dependency to remaining veneer Gemfiles
google-cloud-core/Gemfile | 1 +
google-cloud-core/Gemfile.lock | 11 +++++++++++
google-cloud-datastore/Gemfile | 1 +
google-cloud-dns/Gemfile | 1 +
google-cloud-error_reporting/Gemfile | 1 +
google-cloud-errors/Gemfile | 1 +
google-cloud-errors/Gemfile.lock | 11 +++++++++++
google-cloud-firestore/Gemfile | 1 +
google-cloud-trace/Gemfile | 1 +
google-cloud-translate-v2/Gemfile | 1 +
stackdriver-core/Gemfile | 1 +
11 files changed, 31 insertions(+)
… from 5 acceptance helpers
aandreassa
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write minitest execution output to JUnit XML reports. This enables centralized test result indexing, flake tracing, and build health metrics reporting inside TestGrid dashboards.