Skip to content

Audio player tidying but without breaking things - #16402

Merged
frederickobrien merged 2 commits into
mainfrom
revert-16401-revert-16339-audio-player-tidying
Jul 22, 2026
Merged

Audio player tidying but without breaking things#16402
frederickobrien merged 2 commits into
mainfrom
revert-16401-revert-16339-audio-player-tidying

Conversation

@frederickobrien

@frederickobrien frederickobrien commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Fixes the issues in #16339 which led to #16401, i.e. moving the islands to /components. @arelra has implemented tests in #16403 to guard against this happening again

@frederickobrien frederickobrien self-assigned this Jul 17, 2026
@frederickobrien frederickobrien added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Jul 17, 2026
@frederickobrien frederickobrien added this to the Interactives milestone Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

@frederickobrien
frederickobrien marked this pull request as ready for review July 17, 2026 11:53
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@arelra arelra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frederickobrien
frederickobrien force-pushed the revert-16401-revert-16339-audio-player-tidying branch from 837d34f to 5d709a3 Compare July 22, 2026 09:58
@frederickobrien frederickobrien added the run_chromatic Runs chromatic when label is applied label Jul 22, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 22, 2026
@frederickobrien
frederickobrien added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit d20d00d Jul 22, 2026
37 checks passed
@frederickobrien
frederickobrien deleted the revert-16401-revert-16339-audio-player-tidying branch July 22, 2026 10:35
@gu-prout

gu-prout Bot commented Jul 22, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @frederickobrien 16 minutes and 53 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants