Repository navigation
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
yepezjuan
left a comment
There was a problem hiding this comment.
Great job on making the change. Thank you for adding visuals to make the changes. PR was well documented
yepezjuan
left a comment
There was a problem hiding this comment.
Great job on making the change. Thank you for adding visuals to make the changes. PR was well documented.
|
ETA: 10/29 EOD |
|
ETA: 10/28/2026 5pm |
Tomomi-K1
left a comment
There was a problem hiding this comment.
Thank you for taking on this issue 👍
- branches are correct
- changes requested in the issue is applied
- verified changes are correct on my local env.
Small suggestion: Would be great you could also add before and after of project page filtered by ATLAS.ti
|
Review ETA: 8 PM PST 10/27/26 |
KyleA99
left a comment
There was a problem hiding this comment.
Great job @ARome9
- PR is merging into the proper target branch.
- Issue is properly linked.
- I think your "Visuals after changes are applied" image may not be accurate. It looks like the
ATLAS.tiis present in the tools section, not the technologies. However, your code looks correct, and I ran the build locally with your branch and it looks correct, so I will still approve the PR. Only mentioning in case other reviewers see that discrepancy and are confused.
anthonylo87
left a comment
There was a problem hiding this comment.
Hi @ARome9,
Thanks for working on this issue. A few changes that I'd like to request:
- See Kyle's note above - the screenshot that you've included in the "Visuals after changes are applied" section isn't quite right - I'd expect to see "ATLAS.ti" in the Technologies section, instead of the Tools section.
- Issue #8570 indicates there should be two "before" and two "after" screenshots (4 total) - one screenshot from the Projects page with the filter being applied, and the other being the Food Oasis page (which you already have). If you could please revise your screenshots to match this that would be great, thanks!
Hello @anthonylo87, thanks for the feedback. I've retested my changes and added new screenshots for the after. However, when reverting my changes and filtering, ATLAS.ti remains under technologies on the Food Oasis card. Therefore, I can only attach one screenshot for the before section. I'd be happy to discuss if there are any doubts. Re-requesting a review of this PR for now. Thanks! |
anthonylo87
left a comment
There was a problem hiding this comment.
Thanks @ARome9 for making the changes - everything looks good to me now. Aprpoved.
Fixes #8570
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied