Skip to content

Tools and Technologies Fix on Food Oasis Page - #8857

Open
ARome9 wants to merge 2 commits into
hackforla:gh-pagesfrom
ARome9:name-fix-food-oasis-8570
Open

ARome9 wants to merge 2 commits into
hackforla:gh-pagesfrom
ARome9:name-fix-food-oasis-8570

Conversation

@ARome9

@ARome9 ARome9 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Fixes #8570

What changes did you make?

  • Changed AtlasTI to ATLAS.ti

Why did you make the changes (we will use this info to test)?

  • Fix inconsistencies for users and site navigation

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image
image

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ARome9-name-fix-food-oasis-8570 gh-pages
git pull https://github.com/ARome9/website.git name-fix-food-oasis-8570

@github-actions github-actions Bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Oct 27, 2026
@yepezjuan
yepezjuan self-requested a review October 27, 2026 20:38

@yepezjuan yepezjuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on making the change. Thank you for adding visuals to make the changes. PR was well documented

@yepezjuan yepezjuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on making the change. Thank you for adding visuals to make the changes. PR was well documented.

@anthonylo87

Copy link
Copy Markdown
Member

ETA: 10/29 EOD
Availability: Evenings PST

@HackforLABot HackforLABot mentioned this pull request Oct 28, 2026
16 of 34 tasks
@Tomomi-K1
Tomomi-K1 self-requested a review October 28, 2026 02:17
@Tomomi-K1

Copy link
Copy Markdown
Member

ETA: 10/28/2026 5pm
Availability: weekday 10am-5pm

@Tomomi-K1 Tomomi-K1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking on this issue 👍

  • branches are correct
  • changes requested in the issue is applied
  • verified changes are correct on my local env.

Small suggestion: Would be great you could also add before and after of project page filtered by ATLAS.ti

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 28, 2026
@KyleA99
KyleA99 self-requested a review October 28, 2026 02:34
@KyleA99

KyleA99 commented Oct 28, 2026

Copy link
Copy Markdown
Member

Review ETA: 8 PM PST 10/27/26
Availability: 7:45-9:00 PM Monday

@KyleA99 KyleA99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @ARome9

  • PR is merging into the proper target branch.
  • Issue is properly linked.
  • I think your "Visuals after changes are applied" image may not be accurate. It looks like the ATLAS.ti is present in the tools section, not the technologies. However, your code looks correct, and I ran the build locally with your branch and it looks correct, so I will still approve the PR. Only mentioning in case other reviewers see that discrepancy and are confused.

@anthonylo87 anthonylo87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ARome9,

Thanks for working on this issue. A few changes that I'd like to request:

  • See Kyle's note above - the screenshot that you've included in the "Visuals after changes are applied" section isn't quite right - I'd expect to see "ATLAS.ti" in the Technologies section, instead of the Tools section.
  • Issue #8570 indicates there should be two "before" and two "after" screenshots (4 total) - one screenshot from the Projects page with the filter being applied, and the other being the Food Oasis page (which you already have). If you could please revise your screenshots to match this that would be great, thanks!

@github-project-automation github-project-automation Bot moved this from PRs ✅ waiting for merge team to PRs being reviewed in P: HfLA Website: Project Board Oct 29, 2026
@ARome9

ARome9 commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Hi @ARome9,

Thanks for working on this issue. A few changes that I'd like to request:

  • See Kyle's note above - the screenshot that you've included in the "Visuals after changes are applied" section isn't quite right - I'd expect to see "ATLAS.ti" in the Technologies section, instead of the Tools section.
  • Issue Fix Name Inconsistency in food-oasis.md file #8570 indicates there should be two "before" and two "after" screenshots (4 total) - one screenshot from the Projects page with the filter being applied, and the other being the Food Oasis page (which you already have). If you could please revise your screenshots to match this that would be great, thanks!

Hello @anthonylo87, thanks for the feedback. I've retested my changes and added new screenshots for the after. However, when reverting my changes and filtering, ATLAS.ti remains under technologies on the Food Oasis card. Therefore, I can only attach one screenshot for the before section. I'd be happy to discuss if there are any doubts. Re-requesting a review of this PR for now. Thanks!

@anthonylo87 anthonylo87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ARome9 for making the changes - everything looks good to me now. Aprpoved.

@github-project-automation github-project-automation Bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Fix Name Inconsistency in food-oasis.md file

5 participants