[python] Test: disable incremental linking for Windows AOT runtime test modules - #9415
Draft
alexreinking wants to merge 1 commit into
Draft
[python] Test: disable incremental linking for Windows AOT runtime test modules#9415alexreinking wants to merge 1 commit into
alexreinking wants to merge 1 commit into
Conversation
…ules
The runtime module test targets link a Halide-generated AOT static
library into a DLL with /WHOLEARCHIVE. On the Windows CI matrix, which
reconfigures and rebuilds the same tree for many Halide_TARGETs in a
row, this has intermittently failed with LNK1236 ("corrupt or invalid
COFF sections") when relinking against a changed archive. These
modules are one-shot build artifacts, so incremental linking has
nothing to offer and is a plausible source of the corruption.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9415 +/- ##
==========================================
+ Coverage 70.00% 70.17% +0.16%
==========================================
Files 261 261
Lines 79402 79402
Branches 19360 19360
==========================================
+ Hits 55586 55719 +133
+ Misses 17941 17889 -52
+ Partials 5875 5794 -81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a test, not a confirmed fix. Opening as draft to see whether it actually resolves the flake before merging.
Our Windows CI buildbots have been intermittently failing
python_bindings/halide-runtime/test/CMakeLists.txt'sruntimeadd.dlllink with:This always occurs on the last target reconfigure in the CI matrix (
x86-64-windows→x86-64-windows-sse41), always on theruntimeaddmodule specifically (nevercallconv/callconv_xor, which are built the same way), and so far only on one of our two Windows workers. The CI recipe reconfigures and rebuilds the same build tree in place for ~9 differentHalide_TARGETs, so this module gets relinked with/INCREMENTALagainst a changed/WHOLEARCHIVEstatic library many times per job — a pattern with a documented history of tripping MSVC's incremental linker.This PR disables incremental linking for these MSVC module targets. They're one-shot build artifacts (loaded by a Python test, never iterated on interactively), so incremental linking buys nothing.
Since this flake is intermittent and worker-specific, we don't yet know if this is the actual root cause or just a plausible contributor — keeping this as a draft until we've seen enough CI runs to tell.
Test plan
LNK1236no longer occurs on the previously-affected worker.