Skip to content

Print the actual Expr for an add_requirement() that fails. - #9424

Merged
mcourteaux merged 2 commits into
mainfrom
mcourteaux/add-requirement-string
Sep 3, 2026
Merged

Print the actual Expr for an add_requirement() that fails.#9424
mcourteaux merged 2 commits into
mainfrom
mcourteaux/add-requirement-string

Conversation

@mcourteaux

Copy link
Copy Markdown
Contributor

Cherry picked from #9337.

A requirement that fails got simplified to false before being turned into a string.
This PR stringifies the Expr upon registering the requirement. This is way more meaningful than reading false at all times.

Checklist

  • Tests added or updated (not required for docs, CI config, or typo fixes)
  • Documentation updated (if public API changed)
  • Python bindings updated (if public API changed)
  • Benchmarks are included here if the change is intended to affect performance.
  • Commits include AI attribution where applicable (see Code of Conduct)

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.03%. Comparing base (6e5de35) to head (0e1f87a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9424      +/-   ##
==========================================
+ Coverage   69.93%   70.03%   +0.10%     
==========================================
  Files         261      261              
  Lines       79410    79412       +2     
  Branches    19363    19363              
==========================================
+ Hits        55532    55618      +86     
+ Misses      17937    17916      -21     
+ Partials     5941     5878      -63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcourteaux
mcourteaux merged commit 9c8bb62 into main Sep 3, 2026
25 checks passed
@alexreinking
alexreinking deleted the mcourteaux/add-requirement-string branch September 3, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants