Repository navigation
Conversation
…starters The next bucket (19+) runs keyless on handsontable.com, so the starters under examples/ and the blank templates generated for the next bucket carry a commented-out licenseKey line pointing at the license key docs page. Buckets 15-18 are pinned to Handsontable versions that still need the non-commercial key and keep it. Generated starter-examples and docs-examples are not touched; they are regenerated after merge. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part of PRO-1359: the non-commercial key (
non-commercial-and-evaluation) leaves everything we ship, since the grid runs keyless on handsontable.com. This PR replaces it with a commented-outlicenseKeyplaceholder that links to the pricing page, in the 15 starters underexamples/and in theblanktemplates generated for thenextbucket (runner/pipeline/blank-starters.mjs). Buckets 15-18 stay on the key because their pinned Handsontable versions still need it.server-examples/*(pinned^18.0.0) will follow in a separate PR after the 19.0 release. Generatedstarter-examples/anddocs-examples/are not touched, they are regenerated after merge.Types of changes
runner/) changeHow was this verified?
blank-starters.test.mjscase written first and seen failing:nextcarries only the placeholder, buckets 15-18 keep the key.node --test pipeline/*.test.mjsinrunner/: 2767 pass, 0 fail..ts/.tsx/.js/.jsxfile parses with no syntax errors (TypeScripttranspileModule, JSX preserved). The//comment sits between JSX attributes; Vue uses an HTML comment above<HotTable>because a tag cannot hold one.nextstarter. Do that before taking this out of draft.Checklist
pnpm build(andpnpm dev) in the affected example/server-example locally: not run, comment-only change in the examples; syntax checked as aboveRelated issue(s):