docs: clarify Node.js default for route.options.timeout.socket#4587
Closed
Hashim1999164 wants to merge 1 commit into
Closed
docs: clarify Node.js default for route.options.timeout.socket#4587Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Node.js no longer times out sockets by default since v13.0.0; the previous 2-minute default is outdated. Update API.md and type docs to match current Node behavior. Closes hapijs#4468
kanongil
added
the
follow instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
route.options.timeout.socketdocs to match Node.js behavior since v13.0.0 (no default socket timeout; older versions used 2 minutes).lib/types/route.d.ts.Closes #4468
Test plan
server.timeouthistorytimeout.socketin the type definitions