Skip to content

Pin adapter reviews to the validated PR revision - #2

Open
anson627 wants to merge 2 commits into
harbor-framework:mainfrom
anson627:codex/adapter-review-freshness
Open

anson627 wants to merge 2 commits into
harbor-framework:mainfrom
anson627:codex/adapter-review-freshness

Conversation

@anson627

@anson627 anson627 commented Sep 30, 2026 •

Copy link
Copy Markdown

This change shares the captured head SHA between structural validation and AI review, checks it before Claude call and before publication, and labels reports with the reviewed revision, A previous review on older commits produces a retry notice instead of publishing its findings.

Validation: actionlint with ShellCheck, git diff --check, and seven mocked checks covering current/changed/closed PRs and missing reports passed. A live GitHub/Claude run has not been exercised.

@anson627
anson627 force-pushed the codex/adapter-review-freshness branch from ab689ab to cea1e2d Compare September 30, 2026 22:35
@anson627
anson627 marked this pull request as ready for review September 30, 2026 22:36

@crystalxyz crystalxyz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment but otherwise it looks good!

|| github.event.comment.author_association == 'CONTRIBUTOR'
)
needs: structural-validation
if: needs.structural-validation.outputs.adapters != ''

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we would want anyone to run /review-adapters? It's probably fine, but i'm not sure if this will cost us more due to API usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants