update mrml to 6.0.1 and enable inline styles - #38
Open
cristofercruz wants to merge 1 commit into
Open
Conversation
Enable the css-inline feature so CSS in `mj-style inline="inline"` is merged into the style attributes of the elements it matches, which is what most email clients need. Plain mj-style tags keep rendering into a <style> tag in the head. Templates that don't use the attribute are unaffected: mrml only runs the inliner when the header collected inline styles, and their output is byte-identical with and without the feature. Also clone the parsed tree directly rather than reparsing to_mjml output. mrml's Printable impl for MjStyle doesn't emit the inline attribute, so the previous implementation silently dropped inlining from clone/dup. Cloning the struct also avoids a full reparse and an unwrap panic path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the css-inline feature so CSS in
mj-style inline="inline"is merged into the style attributes of the elements it matches, which is what most email clients need. Plain mj-style tags keep rendering into a <style> tag in the head.Templates that don't use the attribute are unaffected: mrml only runs the inliner when the header collected inline styles, and their output is byte-identical with and without the feature.
Also clone the parsed tree directly rather than reparsing to_mjml output. mrml's Printable impl for MjStyle doesn't emit the inline attribute, so the previous implementation silently dropped inlining from clone/dup. Cloning the struct also avoids a full reparse and an unwrap panic path.