Repository navigation
test-qc: replace deprecated TypeInType pragma - #448
Merged
Merged
Conversation
Contributor
|
Thanks! Did you generate the PR description with an LLM? The table and everything after add no relevant information. For future contributions, I'd recommend leaving out such fluff. |
Contributor
Author
|
Sure, will keep it short and only add extra detail when asked. Thanks for looking at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
TypeInTypepragma intest/Main.hswithDataKindsandPolyKinds, as GHC recommends, retaining the existing CPP guard. Fixes #447.Verified on Linux with GHC 9.14.1 against current master (
2fdb2a9):test-qcsuite with-Wall -Wcompat -WerrorGHC-53692:-XTypeInType is deprecatedThe existing suite itself reproduces the problem; no new test harness or assertions are needed. This changes only test pragmas, with no library/API changes, dependency-bound changes, additional warning suppression or removed tests. Master's existing library warning allowances from #434 remain unchanged.
The comparison used Cabal 3.16.1.0, optimization level 2, the pinned dependency configuration in #447, and
cabal test all --test-show-details=direct. The fresh build directory reused the earlier experiment's dependency store. Full commands, logs and plan are available on request.Existing CI already builds and runs
test-qcacross its compiler matrix, including GHC 9.14. It does not currently enforce-Werror; the strict before/after check above was run locally. Older compilers and the other operating systems remain for CI verification after submission.