Skip to content

ci: improve clippy job - #2634

Merged
mkroening merged 4 commits into
mainfrom
ci-clippy
Aug 12, 2026
Merged

ci: improve clippy job#2634
mkroening merged 4 commits into
mainfrom
ci-clippy

Conversation

@mkroening

@mkroening mkroening commented Aug 12, 2026

Copy link
Copy Markdown
Member

This should catch #2633 in the future.

@mkroening mkroening self-assigned this Aug 12, 2026
@fogti

fogti commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Why exactly do we have cargo xtask clippy if we don't use it in CI?

@mkroening

Copy link
Copy Markdown
Member Author

Why exactly do we have cargo xtask clippy if we don't use it in CI?

We did use it once but found it not to be sufficient. Hence the migration to cargo-hack. I am planning to make this nicer in the future, though.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 044ace0 Previous: 2e23902 Performance Ratio
startup_benchmark Build Time 224.04 s 80.34 s 2.79
startup_benchmark File Size 0.78 MB 0.80 MB 0.99
Startup Time - 1 core 2.17 s (±0.30 s) 0.75 s (±0.02 s) 2.91
Startup Time - 2 cores 2.29 s (±0.25 s) 0.74 s (±0.02 s) 3.11
Startup Time - 4 cores 2.27 s (±0.27 s) 0.74 s (±0.02 s) 3.06
multithreaded_benchmark Build Time 221.71 s 82.11 s 2.70
multithreaded_benchmark File Size 0.84 MB 0.86 MB 0.98
Multithreaded Pi Efficiency - 2 Threads 81.62 % (±13.30 %) 85.89 % (±6.61 %) 0.95
Multithreaded Pi Efficiency - 4 Threads 54.03 % (±10.31 %) 43.43 % (±2.56 %) 1.24
Multithreaded Pi Efficiency - 8 Threads 32.88 % (±6.70 %) 25.76 % (±1.53 %) 1.28
micro_benchmarks Build Time 200.24 s 80.40 s 2.49
micro_benchmarks File Size 0.85 MB 0.86 MB 0.98
Scheduling time - 1 thread 159.45 ticks (±37.25 ticks) 62.65 ticks (±4.06 ticks) 2.54
Scheduling time - 2 threads 94.82 ticks (±15.69 ticks) 34.08 ticks (±4.10 ticks) 2.78
Micro - Time for syscall (getpid) 9.10 ticks (±3.85 ticks) 3.45 ticks (±0.58 ticks) 2.64
Memcpy speed - (built_in) block size 4096 58195.29 MByte/s (±40764.65 MByte/s) 82448.38 MByte/s (±56997.13 MByte/s) 0.71
Memcpy speed - (built_in) block size 1048576 16291.33 MByte/s (±14774.20 MByte/s) 30585.98 MByte/s (±24707.84 MByte/s) 0.53
Memcpy speed - (built_in) block size 16777216 12228.48 MByte/s (±10076.63 MByte/s) 26340.06 MByte/s (±21720.96 MByte/s) 0.46
Memset speed - (built_in) block size 4096 58136.23 MByte/s (±40725.53 MByte/s) 82292.76 MByte/s (±56891.50 MByte/s) 0.71
Memset speed - (built_in) block size 1048576 16652.74 MByte/s (±14929.87 MByte/s) 31323.85 MByte/s (±25145.86 MByte/s) 0.53
Memset speed - (built_in) block size 16777216 12427.19 MByte/s (±10168.32 MByte/s) 27104.68 MByte/s (±22209.94 MByte/s) 0.46
Memcpy speed - (rust) block size 4096 50842.46 MByte/s (±36188.49 MByte/s) 74097.96 MByte/s (±51811.44 MByte/s) 0.69
Memcpy speed - (rust) block size 1048576 16707.13 MByte/s (±14817.11 MByte/s) 30361.60 MByte/s (±24602.37 MByte/s) 0.55
Memcpy speed - (rust) block size 16777216 12156.42 MByte/s (±9952.62 MByte/s) 27625.34 MByte/s (±22806.88 MByte/s) 0.44
Memset speed - (rust) block size 4096 51310.34 MByte/s (±36485.11 MByte/s) 74373.47 MByte/s (±51976.48 MByte/s) 0.69
Memset speed - (rust) block size 1048576 16967.84 MByte/s (±14914.57 MByte/s) 31110.89 MByte/s (±25033.24 MByte/s) 0.55
Memset speed - (rust) block size 16777216 12249.35 MByte/s (±9981.49 MByte/s) 28386.93 MByte/s (±23265.03 MByte/s) 0.43
alloc_benchmarks Build Time 204.19 s 74.76 s 2.73
alloc_benchmarks File Size 0.86 MB 0.87 MB 0.99
Allocations - Allocation success 91.35 % 91.31 % 1.00
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 61.55 % 61.44 % 1.00
Allocations - Average Allocation time 7571.36 Ticks (±2308.29 Ticks) 5860.58 Ticks (±98.43 Ticks) 1.29
Allocations - Average Allocation time (no fail) 9512.19 Ticks (±2142.12 Ticks) 6554.81 Ticks (±92.86 Ticks) 1.45
Allocations - Average Deallocation time 2524.44 Ticks (±777.49 Ticks) 1805.01 Ticks (±250.35 Ticks) 1.40
mutex_benchmark Build Time 199.26 s 79.82 s 2.50
mutex_benchmark File Size 0.85 MB 0.86 MB 0.98
Mutex Stress Test Average Time per Iteration - 1 Threads 30.90 ns (±5.51 ns) 12.10 ns (±0.41 ns) 2.55
Mutex Stress Test Average Time per Iteration - 2 Threads 31.24 ns (±8.00 ns) 40.26 ns (±1.68 ns) 0.78

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening
mkroening added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit 81014bf Aug 12, 2026
57 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants