Skip to content

refactor: give annotations a value type - #1328

Open
lukasmetzner wants to merge 1 commit into
mainfrom
split/core-a-typed-annotations
Open

refactor: give annotations a value type#1328
lukasmetzner wants to merge 1 commit into
mainfrom
split/core-a-typed-annotations

Conversation

@lukasmetzner

Copy link
Copy Markdown
Contributor

This is needed for an upcoming refactor, where a Load Balancer spec is built
from a corev1.Service object.

Additionally, we have a more stable doc generation, as we don't have to sync
the comment text with the targeted type.

This is needed for an upcoming refactor, where a Load Balancer spec is built
from a corev1.Service object.

Additionally, we have a more stable doc generation, as we don't have to sync
the comment text with the targeted type.
@lukasmetzner
lukasmetzner requested a review from a team as a code owner August 19, 2026 11:16
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.96992% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.11%. Comparing base (6485324) to head (19944e7).

Files with missing lines Patch % Lines
tools/doc_generation.go 0.00% 11 Missing ⚠️
internal/hcops/load_balancer.go 91.83% 2 Missing and 2 partials ⚠️
hcloud/load_balancers.go 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
- Coverage   71.26%   70.11%   -1.16%     
==========================================
  Files          29       29              
  Lines        2875     2794      -81     
==========================================
- Hits         2049     1959      -90     
- Misses        635      643       +8     
- Partials      191      192       +1     
Flag Coverage Δ
e2e 45.10% <73.77%> (+0.33%) ⬆️
unit 66.49% <87.21%> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant