Skip to content

build(chrome): pin chrome-headless-shell 158.0.8127.36 wherever the repo installs it - #8145

Merged
jrusso1020 merged 1 commit into
mainfrom
rames/cli-chrome-158
Nov 18, 2026
Merged

jrusso1020 merged 1 commit into
mainfrom
rames/cli-chrome-158

Conversation

@jrusso1020

Copy link
Copy Markdown
Collaborator

What

The pinned chrome-headless-shell moves from Beta 152.0.7977.30 to stable 158.0.8127.36. Every place the repo installs the shell now follows that pin, and the chat regression golden is regenerated on 158.

Why

152 was a Beta build, and stable has since moved several majors ahead. Several installs had also drifted from the engine pin: the CI test workspace and the CLI's amd64 render image installed @stable, the motion-blur nightly pinned 153, and the regression image and examples pinned 152. One pin means the CLI, CI, the regression goldens and the published Docker examples all render with the same browser.

Golden change. On Chrome 157 and later, a background-clip: text gradient phrase shows its word spans as soon as the phrase becomes visible, even while each span is still at opacity: 0 with a transform. Chrome 152 kept them hidden until their own entrance. The chat fixture's "THANK YOU" outro hits this, at frames 420–426. Chrome 157 renders that fixture pixel-identically to 158, so the old golden recorded the 152 behaviour, not a 158 regression. Compositions that need the per-word entrance can put the gradient on each word instead of on the parent; that form renders the same on 152 and 158.

Related work

Refs the earlier Beta pin in 556fe93 (#3231).

How

  • packages/engine/src/services/chromeHostCeiling.ts: CHROME_VERSION 158.0.8127.36 and its Chrome for Testing digests (PINNED_SHELL_DIGESTS). It was generated with bun run --cwd packages/cli pin:chrome.
  • The installs that now follow the pin:
    • Dockerfile.test;
    • .github/actions/setup-test-workspace (was @stable);
    • packages/cli/src/docker/Dockerfile.render (amd64; was @stable);
    • examples/k8s-jobs/Dockerfile.example;
    • packages/gcp-cloud-run/Dockerfile (with its sha256) and its doc page;
    • the Lambda build-zip.ts install hint;
    • the CLI's system-Chrome warning, which now names the pinned version.
  • Motion-blur nightly: it still compares the pinned shell against stable. The pin leg now uses the workspace's pinned shell (158), and a new step fetches @stable for the stable leg. Before this, the pin leg ran 153 and the stable leg came from the workspace action.
  • Not moved, and why:
    • ci.yml full Chrome 156.0.8078.47: it moves together with packages/studio/tests/e2e/perf-ceilings.json, which has to be re-measured on 158 first.
    • The arm64 render image uses Playwright's Chromium, which was adopted to fix an arm64 startup crash. Chrome for Testing now publishes a linux-arm64 shell for 158, so switching it is a follow-up that needs an arm64 render to check.
    • @sparticuz/chromium 148.0.0 for Lambda: its newest release is 153. It's a Lambda-specific build with its own arm64 pack and a beginFrame probe.
    • The puppeteer and puppeteer-core versions: the newest release bundles 157. Every launch path except one passes the pinned shell's path; verifyStaticPage falls back to the bundled browser only when PUPPETEER_EXECUTABLE_PATH is unset.
    • The macOS 12 workaround stays on 150, because 152 and later don't start there.
    • Apt chromium fallbacks and the deliberately unpinned full-Chrome setup-chrome: stable installs are unchanged.

Test plan

  • Chat golden: docker:test:update chat in the 158 test image, then docker:test chat against the new golden passes: 0 failed frames, audio correlation 1.000, compilation unchanged.
  • Unit tests: packages/cli manager.test.ts (85/85), the engine browserManager.test.ts expectations, packages/aws-lambda build-zip.test.ts (1/1) and the CI workflow tests (34/34). The pre-commit lint, format, fallow and typecheck hooks also pass.
  • Pinned shell: the linux64 sha256 checks out and --version reports Google Chrome for Testing 158.0.8127.36.
  • The full regression suite and the motion-blur nightly run in CI.
Claude Opus 5.5

Repro of the paint change

A phrase with background-clip:text and -webkit-text-fill-color: transparent, with display:inline-block word spans at opacity:0 and a transform. The phrase's opacity goes from 0 to 1 while the words stay hidden.

Lit pixels in a 900×200 frame:

Frame 152.0.7977.30 157.0.8103.78 158.0.8127.36
Phrase shown, both words at opacity 0 0 12,383 12,383
Word 1 at opacity 0.6 mid-transform, word 2 not started 7,839 12,383 12,383

157 and 158 are byte-identical in both frames. On those builds the words paint at full opacity in their final layout position.

Why compiled.html is unchanged

--update also rewrites the fixture's compiled HTML snapshot. That snapshot only tracks compiler output, not the browser, and the existing one still validates. So this PR keeps it, and the golden change is only output.mp4.

🤖 Generated with Claude Code

…epo installs it

The engine ceiling moves from Beta 152.0.7977.30 to stable 158.0.8127.36, with its Chrome for
Testing digests. The places that installed `@stable` or an older pin follow it: the CI test
workspace, the regression test image, the k8s and Cloud Run examples, the CLI render image
(amd64) and the Lambda build hint. The motion-blur nightly keeps its pinned-versus-stable
comparison: the pin leg now uses the workspace's pinned shell, and a stable leg fetches stable.

The chat regression golden is regenerated on 158. Chrome 157 renders it pixel-identically to
158, so the previous golden recorded Chrome 152's paint of a background-clip:text phrase whose
word spans start at opacity 0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mintlify

mintlify Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
hyperframes 🟢 Ready View Preview Nov 18, 2026, 6:53 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@github-actions

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 271 (base branch 271), smooth 65 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (0)

Unstable (3)

  • seqab-none-px-r0-root-z100: tracking 0.03, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.03, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.03, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true
  • seqrepeat-none-center-r0-root-z100: tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true / tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true / tracking 0.05, pressJump 0, drop 0, reload 0, render 0.02, renderKey -, undo true, teleport true
  • seqplainkeys-none-px-r0-nested-z100: tracking 0.07, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.07, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true / tracking 0.07, pressJump 0, drop 0, reload 0, render 0.03, renderKey -, undo true, teleport true

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving at 0ff0cd38.

  • Digests match the version. I recomputed headlessShellDigest independently from Chrome for Testing's own 158.0.8127.36 archives: SHA-256 over the sorted name\0sha256\n lines of each shell folder, debug.log excluded. All five equal PINNED_SHELL_DIGESTS["158.0.8127.36"], in order: mac-arm64 564ba987…, mac-x64 32499804…, linux64 2ba780aa…, win32 ca7a3db1…, win64 dee5819f…. No folder holds a link. The 150 entry is unchanged, as macOS 12 still gets 150.
  • The Cloud Run archive hash matches. chrome-headless-shell-linux64.zip for 158.0.8127.36 hashes to 2d3a2301…b73a, the new CHROME_HEADLESS_SHELL_SHA256_AMD64.
  • Nothing installs the old pin or an unpinned shell any more. The setup-test-workspace action, Dockerfile.test, the amd64 branch of Dockerfile.render, the k8s example, the Cloud Run Dockerfile, the Lambda hint and the CLI's fallback warning all name 158.0.8127.36 or managedChromeVersion(). The only @stable install left is the nightly's deliberate stable leg; its matrix is still [pin, stable], and the pin leg now takes the workspace's pinned shell. The remaining 152.0.7977.30 strings are mocked browser-version strings in test fixtures, plus changelog history.
  • CI is green at this head.

Non-blocking: browserManager.test.ts:1682-1717 still builds 152.0.7977.30 folders next to 150.0.7871.124. The tests pass because they're about the locked or partial folder, not the version. Moving them to the managed version would keep them reading as current.

@jrusso1020
jrusso1020 added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 7930525 Nov 18, 2026
100 checks passed
@jrusso1020
jrusso1020 deleted the rames/cli-chrome-158 branch November 18, 2026 07:38

This branch was successfully deployed

1 active deployment
staging - docs — 0ff0cd38 Deployed Nov 18, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants