Repository navigation
build(chrome): pin chrome-headless-shell 158.0.8127.36 wherever the repo installs it - #8145
Merged
Merged
Conversation
…epo installs it The engine ceiling moves from Beta 152.0.7977.30 to stable 158.0.8127.36, with its Chrome for Testing digests. The places that installed `@stable` or an older pin follow it: the CI test workspace, the regression test image, the k8s and Cloud Run examples, the CLI render image (amd64) and the Lambda build hint. The motion-blur nightly keeps its pinned-versus-stable comparison: the pin leg now uses the workspace's pinned shell, and a stable leg fetches stable. The chat regression golden is regenerated on 158. Chrome 157 renders it pixel-identically to 158, so the previous golden recorded Chrome 152's paint of a background-clip:text phrase whose word spans start at opacity 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Contributor
Edit accuracy: accurate 271 (base branch 271), smooth 65 of thoseThe gate passes. Quarantined, measured but not gated (0) Unstable (3)
|
miguel-heygen
approved these changes
Nov 18, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Approving at 0ff0cd38.
- Digests match the version. I recomputed
headlessShellDigestindependently from Chrome for Testing's own 158.0.8127.36 archives: SHA-256 over the sortedname\0sha256\nlines of each shell folder,debug.logexcluded. All five equalPINNED_SHELL_DIGESTS["158.0.8127.36"], in order: mac-arm64564ba987…, mac-x6432499804…, linux642ba780aa…, win32ca7a3db1…, win64dee5819f…. No folder holds a link. The 150 entry is unchanged, as macOS 12 still gets 150. - The Cloud Run archive hash matches.
chrome-headless-shell-linux64.zipfor 158.0.8127.36 hashes to2d3a2301…b73a, the newCHROME_HEADLESS_SHELL_SHA256_AMD64. - Nothing installs the old pin or an unpinned shell any more. The setup-test-workspace action,
Dockerfile.test, the amd64 branch ofDockerfile.render, the k8s example, the Cloud Run Dockerfile, the Lambda hint and the CLI's fallback warning all name 158.0.8127.36 ormanagedChromeVersion(). The only@stableinstall left is the nightly's deliberate stable leg; its matrix is still[pin, stable], and the pin leg now takes the workspace's pinned shell. The remaining152.0.7977.30strings are mocked browser-version strings in test fixtures, plus changelog history. - CI is green at this head.
Non-blocking: browserManager.test.ts:1682-1717 still builds 152.0.7977.30 folders next to 150.0.7871.124. The tests pass because they're about the locked or partial folder, not the version. Moving them to the managed version would keep them reading as current.
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pinned
chrome-headless-shellmoves from Beta 152.0.7977.30 to stable 158.0.8127.36. Every place the repo installs the shell now follows that pin, and the chat regression golden is regenerated on 158.Why
152 was a Beta build, and stable has since moved several majors ahead. Several installs had also drifted from the engine pin: the CI test workspace and the CLI's amd64 render image installed
@stable, the motion-blur nightly pinned 153, and the regression image and examples pinned 152. One pin means the CLI, CI, the regression goldens and the published Docker examples all render with the same browser.Golden change. On Chrome 157 and later, a
background-clip: textgradient phrase shows its word spans as soon as the phrase becomes visible, even while each span is still atopacity: 0with a transform. Chrome 152 kept them hidden until their own entrance. The chat fixture's "THANK YOU" outro hits this, at frames 420–426. Chrome 157 renders that fixture pixel-identically to 158, so the old golden recorded the 152 behaviour, not a 158 regression. Compositions that need the per-word entrance can put the gradient on each word instead of on the parent; that form renders the same on 152 and 158.Related work
Refs the earlier Beta pin in 556fe93 (#3231).
How
packages/engine/src/services/chromeHostCeiling.ts:CHROME_VERSION158.0.8127.36 and its Chrome for Testing digests (PINNED_SHELL_DIGESTS). It was generated withbun run --cwd packages/cli pin:chrome.Dockerfile.test;.github/actions/setup-test-workspace(was@stable);packages/cli/src/docker/Dockerfile.render(amd64; was@stable);examples/k8s-jobs/Dockerfile.example;packages/gcp-cloud-run/Dockerfile(with its sha256) and its doc page;build-zip.tsinstall hint;@stablefor the stable leg. Before this, the pin leg ran 153 and the stable leg came from the workspace action.ci.ymlfull Chrome 156.0.8078.47: it moves together withpackages/studio/tests/e2e/perf-ceilings.json, which has to be re-measured on 158 first.@sparticuz/chromium148.0.0 for Lambda: its newest release is 153. It's a Lambda-specific build with its own arm64 pack and abeginFrameprobe.verifyStaticPagefalls back to the bundled browser only whenPUPPETEER_EXECUTABLE_PATHis unset.chromiumfallbacks and the deliberately unpinned full-Chromesetup-chrome: stableinstalls are unchanged.Test plan
docker:test:update chatin the 158 test image, thendocker:test chatagainst the new golden passes: 0 failed frames, audio correlation 1.000, compilation unchanged.packages/climanager.test.ts(85/85), the enginebrowserManager.test.tsexpectations,packages/aws-lambdabuild-zip.test.ts(1/1) and the CI workflow tests (34/34). The pre-commit lint, format, fallow and typecheck hooks also pass.--versionreportsGoogle Chrome for Testing 158.0.8127.36.Claude Opus 5.5
Repro of the paint change
A phrase with
background-clip:textand-webkit-text-fill-color: transparent, withdisplay:inline-blockword spans atopacity:0and a transform. The phrase's opacity goes from 0 to 1 while the words stay hidden.Lit pixels in a 900×200 frame:
157 and 158 are byte-identical in both frames. On those builds the words paint at full opacity in their final layout position.
Why
compiled.htmlis unchanged--updatealso rewrites the fixture's compiled HTML snapshot. That snapshot only tracks compiler output, not the browser, and the existing one still validates. So this PR keeps it, and the golden change is onlyoutput.mp4.🤖 Generated with Claude Code