Repository navigation
Conversation
Run each benchmark configuration 20 times on independent runners. Give runner jobs and artifacts unique suffixes, and skip comment rendering for the repeated configurations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jsturtevant,
ludfjig,
simongdavies,
squillace and
syntactically
as code owners
October 9, 2026 15:52
jprendes
added
kind/enhancement
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Launching 120 self-hosted benchmark jobs warrants human confirmation of capacity and cost.
0 open findings
What changed in this PR
Runs 20 iterations across six benchmark configurations to measure null-comparison noise.
Changes:
- Expands the benchmark matrix to 120 jobs.
- Adds unique runner and artifact suffixes.
- Disables the standard benchmark comment.
| File | Description |
|---|---|
.github/workflows/ValidatePullRequest.yml |
Adds iterations and suppresses reporting. |
.github/workflows/dep_benchmarks.yml |
Applies optional suffixes to runner requests and artifacts. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run each benchmark configuration 20 times to measure null-comparison noise.
Summary
The PR changes workflow files only, so the host benchmark code is identical on both sides of every paired comparison. The run will produce 11,400 comparisons across 120 benchmark jobs.
Validation
just fmt-applyactionlint .github/workflows/dep_benchmarks.yml .github/workflows/ValidatePullRequest.ymljust clippyjust test: 483 passed, 1 unrelated upstream failure inkvm_does_not_expose_cet_to_guest