Repository navigation
BgpSessionDataAggregator: fix logic bug - #1099
Merged
Merged
Conversation
…rameter is unused. since the first parameter to when is a boolean. using this the value provided to the closure as an ASN in the query is now incorrect. rely on when's truthiness check instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BgpSessionDataAggregator::getPeers function takes a parameter (?int $asn = null).
The parameter is not currently used, so nothing should be affected by it so far.
The code passes $asn != null into
when, and then uses the result of that expression as an ASN in the queryIn the closure, $asn is
trueorfalse, which when cast to an int is0or1.Instead we can rely on
whento perform the truthiness check (ensure $asn isn't 0 or null), then typehint $asn as an int, and then the query will work as intended.