Skip to content

fix(ui-side-nav-bar): show focus ring on selected item - #2613

Merged
ToMESSKa merged 1 commit into
masterfrom
INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7
Jul 24, 2026
Merged

fix(ui-side-nav-bar): show focus ring on selected item#2613
ToMESSKa merged 1 commit into
masterfrom
INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7

Conversation

@ToMESSKa

@ToMESSKa ToMESSKa commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

INSTUI-5078

ISSUE:

  • the selected item in SideNavBar (v2) showed no focus ring when focused — the a11y team flagged that users couldn't tell which item was selected/focused

TEST PLAN:

  • check the example in the v2 version of the SideNavBar in the 4 different themes
  • using the Tab, go through the SideNavBar items, each item should have a visible focus ring including the selected "Dashboard" element

@ToMESSKa ToMESSKa self-assigned this Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-24 09:08 UTC

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Visual regression report

No changes.

Status Count
Unchanged 32
Changed 0
New 0
Removed 0

📊 View full report

Baselines come from the visual-baselines branch. They refresh on every merge to master.

github-actions Bot pushed a commit that referenced this pull request Jun 26, 2026
@ToMESSKa
ToMESSKa force-pushed the INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7 branch from dd8aa5c to e9ede98 Compare July 21, 2026 10:21
github-actions Bot pushed a commit that referenced this pull request Jul 21, 2026
@ToMESSKa
ToMESSKa requested a review from matyasf July 21, 2026 11:13
@ToMESSKa
ToMESSKa marked this pull request as ready for review July 21, 2026 11:14
@matyasf
matyasf requested a review from HerrTopi July 22, 2026 09:14
@ToMESSKa
ToMESSKa force-pushed the INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7 branch from e9ede98 to fe10d09 Compare July 24, 2026 08:29
github-actions Bot pushed a commit that referenced this pull request Jul 24, 2026
@ToMESSKa
ToMESSKa merged commit 0dad569 into master Jul 24, 2026
12 checks passed
@ToMESSKa
ToMESSKa deleted the INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7 branch July 24, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants