feat(ui-tag): remove the inline variant from Tag v2 - #2654
Merged
ToMESSKa merged 1 commit intoJul 24, 2026
Conversation
BREAKING CHANGE: the inline variant and the variant prop have been removed from Tag v2. Refs: INSTUI-5127
ToMESSKa
force-pushed
the
INSTUI-5127-remove-the-inline-variant-of-tag-from-v-2
branch
from
July 23, 2026 09:16
230c25e to
69c58fe
Compare
ToMESSKa
changed the title
Contributor
|
Contributor
Visual regression report
Diff images (1)metric-pill-tag-timeselect-text.png — 105269 pixels differBaselines come from the |
matyasf
reviewed
Jul 23, 2026
Comment on lines
-140
to
-147
| backgroundColor: componentTheme.inlineBackground, | ||
| border: `${componentTheme.inlineBorderWidth} ${componentTheme.inlineBorderStyle} ${componentTheme.inlineBorderColor}`, | ||
| borderRadius: componentTheme.inlineBorderRadius, | ||
| color: componentTheme.inlineColor, | ||
| cursor: 'text', | ||
| margin: '0 0.1875rem 0.1875rem', | ||
| ...(isButton && { | ||
| '&:hover': { backgroundColor: componentTheme.inlineBackgroundHover } |
Collaborator
There was a problem hiding this comment.
we should ask design to remove these tokens
matyasf
approved these changes
Jul 23, 2026
ToMESSKa
deleted the
INSTUI-5127-remove-the-inline-variant-of-tag-from-v-2
branch
July 24, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the inline variant and the variant prop have been removed from Tag v2.
Closes: INSTUI-5127
ISSUE:
TEST PLAN: