[AV1 Encode] Handle allocation failures safely - #386
Open
fjdoria76 wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Author
|
hi |
Author
|
Hi! Thanks for stopping by. No action is needed for this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent AV1/QSV workloads can exhaust system or GPU memory and currently allow allocation failures to surface as invalid-resource use or a segmentation fault. This is reported in issue #371 for Jellyfin/FFmpeg on Arc A750.
The change hardens the AV1 encode paths by:
MFX_ERR_MEMORY_ALLOC.std::bad_allocat AV1 init, frame submission, and async execution boundaries into Media SDK errors.Validation:
git diff --checkpasses. An isolated CMake build was attempted but compilation is blocked in this macOS environment becauseva/va_version.his unavailable.Fixes: #371