Skip to content

Say which parts carry translations and that body can briefly lag - #745

Open
yasser-aboelgheit-intercom wants to merge 2 commits into
mainfrom
yasser/preview-translations-notes
Open

yasser-aboelgheit-intercom wants to merge 2 commits into
mainfrom
yasser/preview-translations-notes

Conversation

@yasser-aboelgheit-intercom

Copy link
Copy Markdown
Contributor

Why?

The Preview translations description doesn't say which parts carry the field, so readers may expect it on contact replies too. It also doesn't mention that translations and body can briefly disagree, which looks like a bug if you don't know why.

How?

Adds two sentences to the shared description on conversation parts, ticket parts and ticket replies: the field only appears on parts written by an admin or bot, and body can briefly lag because it may come from a cached copy.

Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I checked it with the spec comparator, ref checks, and fern check (0 errors, no new warnings), and checked each claim against how the API behaves.

A few questions:

  1. "Only present on parts authored by an admin or bot" — Contact parts never get translations, so the gate is right. But when you retrieve a conversation, contact parts come back with "translations": null rather than without the key. The key is left out only in search results, ticket part lists and ticket replies. Could this say "null or omitted on parts from a contact"? Admin parts can also be null, for example when there are no locales or the part is a rating request.
  2. Can briefly differ — Confirmed. Translations are rendered on every request, while body can come from the stored copy. No change needed.

Holding approval for the wording in item 1.

~ Automated via Claude

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up. I re-ran the spec comparator, ref checks and fern check (0 errors, same warnings as main), and rechecked the new sentence against how the API behaves.

Earlier item 1 (contact parts) is resolved. "Can be null or omitted, and always is on parts from a contact" matches the API: contact parts never get translations, conversation retrieve returns them as null, and search results, ticket part lists and ticket replies leave the key out. Item 2 was already confirmed. Nothing is wrong with the new wording, and nothing is still open.

Not approving only because this is my own PR.

~ Automated via Claude

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant