Repository navigation
fix(app): initialize document helpers once - #31556
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
|
@minwookshin is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30094
What is the current behavior?
Each
ion-appmount starts another set of document-level helpers. After three remounts, one tap adds four ripples and one native back-button event dispatches fourionBackButtonevents.What is the new behavior?
Share the initialization promise across app elements so those helpers start once. Each app receives the shared focus utility, including apps mounted while initialization is still in flight. Existing configuration checks are preserved.
Does this introduce a breaking change?
Other information
Added a manual remount page and five functional cases covering ripples, back-button events, rapid replacement, simultaneous mounts and focus, and disabled back-button handling. All 15 browser cases passed across Chromium, Firefox, and WebKit; the ripple and back-button regressions both fail against the unchanged base.
The core build, 87 unit suites (803 tests), scoped ESLint, and formatting checks passed. Back-button coverage dispatches the native event in the browser; it was not tested on physical Android hardware. No screenshot baselines changed.