MLD-1347 - Cursor rewrite mcp.json - #63
Merged
Merged
Conversation
arielamitjfrog
changed the title
YoniMelki
reviewed
Aug 17, 2026
shay-coh
requested changes
Aug 17, 2026
YoniMelki
previously approved these changes
Aug 18, 2026
shay-coh
requested changes
Aug 18, 2026
shay-coh
previously approved these changes
Aug 18, 2026
6 tasks
…D-1347-cursor-rewrite-mcp-json
Contributor
Author
|
@shay-coh to align the Claude plugin behavior, I added a message when the process completes: |
…D-1347-cursor-rewrite-mcp-json
YoniMelki
previously approved these changes
Aug 23, 2026
…D-1347-cursor-rewrite-mcp-json # Conflicts: # .github/scripts/sync-modules-vendor.json # plugins/jfrog/modules/core/rewrite-mcp-json.mjs
YoniMelki
requested changes
Aug 25, 2026
YoniMelki
left a comment
YoniMelki
left a comment
Collaborator
There was a problem hiding this comment.
This pull request does not change plugin.json or marketplace.json.
The two files stay at 0.5.17, the same as main.
Increase the version above 0.5.17 so that Cursor installs the change.
YoniMelki
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionStart, discover pluginmcp.json/.mcp.jsonunder$CURSOR_CONFIG_DIR/plugins/local(plus this plugin’s own config) and run Agent Guard--rewrite-mcp-jsonso stdio MCP entries launch through@jfrog/agent-guard. Remote URL/HTTP/SSE/WS entries are left unchanged; workspace/user.cursor/mcp.jsonis out of scope.scripts/(cursor-mcp-json-discover.mjs+ thincursor-align-mcp-json.mjsadapter). Shared orchestration (project/server resolution, Step 0 gate, spawn/timeout, soft-fail) is vendored intomodules/core/from jfrog-agent-hooks MLD-1386 (a146a13), with rewrite budget set to 35s so it fits under the 45s hook timeout with gate overhead.JF_AGENT_REWRITE_MCP_JSON_DISABLE=1, missing project, gate failure, or rewrite errors. Bumps plugin/marketplace version to 0.5.14. Documents env vars and vendor layout in README /VENDOR.md; addsdest_prefixto modules sync config.Related PRs:
agent-guard- MLD-1375 - Harness-agnostic rewrite plugins mcp.jsonjfrog-agent-hooks- MLD-1386 - Apply cross harnesses logicTest plan
node --test plugins/jfrog/scripts/*.test.mjsJF_PROJECT(or project in existing_JF_ARGS), start a Cursor agent session and confirm the align hook runs without failing session start~/.cursor/plugins/local/*/mcp.jsonis rewritten through@jfrog/agent-guard; remote entries unchangedmcp.jsonis included; workspace/user.cursor/mcp.jsonis notJF_AGENT_REWRITE_MCP_JSON_DISABLE=1skips rewrite