Skip to content

Bump jfrog-cli-core for host-app client identity - #3675

Merged
sverdlov93 merged 7 commits into
masterfrom
feature/ide-only-client-identity
Aug 26, 2026
Merged

sverdlov93 merged 7 commits into
masterfrom
feature/ide-only-client-identity

Conversation

@sverdlov93

@sverdlov93 sverdlov93 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Overview

Pins jfrog-cli-core to the merged host-app client detector and aligns User-Agent tests with that wire.

Details

  • jfrog-cli-core/v2v2.60.1-0.20260826121657-9a951b0bb4b7 (Resolve AI client from host app and tighten session detectors jfrog-cli-core#1613).
  • Claude / cowork: ai-agent/claude ai-client/claude.
  • Windsurf / Antigravity / Trae sessions include matching ai-client/.
  • Cursor session (CURSOR_AGENT) does not imply the window. ai-client/cursor only with CURSOR_TRACE_ID or Cursor askpass. Inherited TERM_PROGRAM=vscode is omitted.
  • Cursor CLI in iTerm is ai-client/iterm; Cursor in stock VS Code askpass is ai-client/vscode.
  • Copilot plugin with no terminal is ai-client/vscode; Copilot in iTerm / JetBrains follows the host.
  • Copilot CLI and Gemini with no host omit ai-client/.
  • Detector env lists are cleared so tests do not leak host IDE, TERM, tmux, or Windows Terminal vars.
flowchart LR
  core[jfrog-cli-core detectors] --> ua[GetCliUserAgent]
  ua --> tests[CLI unit tests]
Loading

Notes

Companion core PR is merged. No local replace.

Companion: jfrog/jfrog-cli-core#1613

Cursor sessions now expect ai-client/cursor; Copilot aliases and kilo-extension omit cases are covered without bumping unpublished core.
@sverdlov93 sverdlov93 added the improvement Automatically generated release notes label Aug 19, 2026
IDE-only client must not follow the terminal program when COPILOT_CLI is set.
Zed, JetBrains and VS Code forks all advertise themselves through env, so an
unisolated test run inside one of those editors would leak its window into the
User-Agent assertions.
@sverdlov93 sverdlov93 changed the title Align User-Agent tests with IDE-only client identity Align User-Agent tests with host-app client identity Aug 26, 2026
@sverdlov93 sverdlov93 changed the title Align User-Agent tests with host-app client identity Bump jfrog-cli-core for host-app client identity Aug 26, 2026
Keep the host-app jfrog-cli-core pin and the Go 1.26 ReverseProxy.Rewrite helper.
@sverdlov93
sverdlov93 enabled auto-merge (squash) August 26, 2026 13:23
@github-actions

Copy link
Copy Markdown
Contributor

@sverdlov93
sverdlov93 merged commit b9d5e9e into master Aug 26, 2026
125 checks passed
@sverdlov93
sverdlov93 deleted the feature/ide-only-client-identity branch August 26, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants