block &newline; entity in attribute filter to stop javascript: bypass - #89
Open
arib06 wants to merge 1 commit into
Open
block &newline; entity in attribute filter to stop javascript: bypass#89arib06 wants to merge 1 commit into
arib06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanAttributes strips the raw tab/newline/cr chars and the &tab;/:/&column; entities before checkAttribute tests a value for a javascript: scheme, but it never removes the html5 &newline; entity, so java&newline;script: passes unflagged and a browser decodes &newline; back to a newline that the url parser then drops to leave javascript:; adding &newline; to blockedChars removes it so the collapsed scheme is detected and stripped.