outputs: save reproducer.sh with the outputs - #79
Merged
Conversation
bhcopeland
reviewed
Aug 14, 2026
| options.metadata = cache_dir / "metadata.json" | ||
| if options.results is None: | ||
| options.results = cache_dir / "results.json" | ||
| save_reproducer(cache_dir, sys.argv) |
Member
There was a problem hiding this comment.
this will leak out avh tokens into output dir
Member
There was a problem hiding this comment.
Also this should be around a try: except: block (oserror/log warning)
Collaborator
Author
There was a problem hiding this comment.
argh, I only fixed the other comment sorry. it is fixed now.
bhcopeland
reviewed
Aug 14, 2026
The mask string "********" is written in two places in mask_secrets(). Move it to SECRET_MASK, so the next user of it does not repeat the literal. No change in behaviour. Add a test for a token that tuxrun did not parse itself, the definition can come from --job-definition. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
"*" is a glob character in the shell and starts an alias in YAML, so both writers have to quote the mask: --secrets 'rootfs:Authorization=********' Authorization: '********' The quotes say nothing, they come from the mask and not from the value. Use XXXXXXXX, it needs no quoting anywhere: --secrets rootfs:Authorization=XXXXXXXX Authorization: XXXXXXXX Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
reproducer-script
branch
from
September 1, 2026 10:38
59cc5f8 to
86da71f
Compare
There is no record of the command line in the output directory. You have to remember what you ran, or find it in the shell history. Save it as reproducer.sh next to the logs and the metadata, when --save-outputs is used. The file is executable, so it runs directly. It is written before the test starts, so it is there also when the test fails. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
mask_secrets() used ruamel only to dump. It loads with yaml_load(), which is PyYAML, so the data has no ruamel style information and preserve_quotes did nothing. Dump with PyYAML instead, it is already a dependency. The output is the same data. A long line is no longer wrapped, a kernel command line stays on one line and is easier to read. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
reproducer-script
branch
from
September 9, 2026 09:33
86da71f to
3861e37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no record of the command line in the output directory. You have to remember what you ran, or find it in the shell history.
Save it as reproducer.sh next to the logs and the metadata, when --save-outputs is used. The file is executable, so it runs directly. It is written before the test starts, so it is there also when the test fails.