chore(test): remove Maestro entirely, iOS e2e is Appium now - #29529
Open
chrisnojima wants to merge 1 commit into
Open
chore(test): remove Maestro entirely, iOS e2e is Appium now#29529chrisnojima wants to merge 1 commit into
chrisnojima wants to merge 1 commit into
Conversation
Delete the Maestro flow tree and its two drivers, along with the iOS
perf-profiling and iOS visual-diff workflows that only Maestro could
drive:
- shared/.maestro/ (performance, subflows, visual-diff yamls)
- perf/run-maestro.sh, perf/visual-diff-take-ios.sh,
perf/visual-diff-compare-ios.sh (orphaned once take-ios is gone)
- yarn perf:ios / perf:{inbox,teams,thread}:ios
- the .maestro entry in the Metro blockList
- the dead Bash(yarn maestro*) permission
Also correct the docs that still pointed at Maestro: the
keybase-e2e-tests and visual-diff skills, plans/flow-test.md,
PERF-TESTING.md (now desktop-only), and the stale "// Maestro: ..."
breadcrumbs left in the Appium flows by the port.
ios/Keybase/PerfFPSMonitor.swift stays: it is gated on the
PERF_FPS_MONITOR launch argument, not on Maestro, and can still be
driven by hand or from Appium.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS functional e2e moved to Appium + WebdriverIO a while back, but the Maestro tree and its docs stayed behind and still read as the live harness. This removes Maestro completely.
Deleted
shared/.maestro/— all 22 yamls (performance, subflows, visual-diff)shared/perf/run-maestro.sh— iOS perf drivershared/perf/visual-diff-take-ios.sh— iOS visual-diff captureshared/perf/visual-diff-compare-ios.sh— orphaned once the capture script is goneyarn perf:ios,perf:inbox:ios,perf:teams:ios,perf:thread:ios.maestroentry in the MetroblockListBash(yarn maestro*)entry in.claude/settings.jsonThis drops iOS perf profiling and iOS visual-diff as workflows — both were Maestro-only and no Appium replacement is written here. Desktop perf and desktop visual-diff are untouched.
Docs corrected
They pointed at Maestro as the iOS harness, which is actively misleading now:
skill/keybase-e2e-tests— description said "iOS (Maestro)"; the body already documented Appiumskill/visual-diff— iOS half removed, desktop workflow promotedplans/flow-test.md— "Maestro command patterns" → Appium/WebdriverIOshared/perf/PERF-TESTING.md— iOS section removed, now desktop-only// Maestro: tapOn ...breadcrumbs left in the Appium flows by the portDeliberately kept
ios/Keybase/PerfFPSMonitor.swift+ itsAppDelegatehook — gated on thePERF_FPS_MONITORlaunch argument, not on Maestro, so it is still drivable by hand or from Appium. Removing it means editing the Xcode project.shared/perf/react-profiler.tsx— imported by six app files and byrun-desktop-perf.js. Its documentation moved into the desktop section.Testing
Docs, comments, and deleted tooling only — no app code changed. The
.tsdiff is comment lines exclusively.shared/package.jsonand.claude/settings.jsonre-parse as valid JSON;shared/metro.config.jsandshared/perf/compare-perf.jspassnode --check.