fix(keycardai-mcp): restore MCP 2.x HTTP connections - #247
Merged
Conversation
Co-Authored-By: Larry Osakwe <larry@keycard.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
The client imports httpx2 in four modules but only received it transitively through mcp.
Larry-Osakwe
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore streamable-HTTP connections against MCP 2.x by passing an owned
httpx2.AsyncClientwith MCP's timeout/redirect defaults, portingHttpxAuthand OAuth challenge handling to httpx2 responses, and consuming the two-stream transport result.The connection now closes both transport and HTTP-client resources, including failed setup paths. Real in-process streamable-HTTP coverage verifies unauthenticated and API-key clients on MCP 2.0.0 and 2.1.0; the full
packages/mcpsuite and Ruff checks pass.Link to Devin session: https://app.devin.ai/sessions/6ca85eacfb404e96adb9a2765dcc2eda
Open in Devin Desktop: https://app.devin.ai/desktop/session/6ca85eacfb404e96adb9a2765dcc2eda?variant=devin
Requested by: @Larry-Osakwe