Skip to content

Reduce redundant mesh diagnostic log collection - #16765

Merged
knative-prow[bot] merged 3 commits into
knative:mainfrom
dprotaso:reduce-mesh-diagnostic-streams
Nov 12, 2026
Merged

knative-prow[bot] merged 3 commits into
knative:mainfrom
dprotaso:reduce-mesh-diagnostic-streams

Conversation

@dprotaso

@dprotaso dprotaso commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Proposed Changes

Use existing Cloud Logging for log history instead of duplicate local copies.

  • Limit Stern to autoscaler/proxy containers in the system, Istio, and all test namespaces, including native sidecars.
  • Remove rotating container-log files; retain cluster/run metadata.
  • Keep live failure triggers and CDS/EDS snapshots to catch transient SAN mismatches before Cloud Logging ingestion.

Normal non-debug logging is unchanged. This reduces diagnostic overhead, not the underlying mesh failures.

Validation

  • go test -race ./test/meshdiagnostics -count=20
  • go vet ./test/meshdiagnostics
  • Shell syntax and diff checks pass. No live-cluster validation.

Release Note

NONE

@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2026
@knative-prow
knative-prow Bot requested review from dsimansk, matzew and skonto November 12, 2026 21:40
@knative-prow

knative-prow Bot commented Nov 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2026
@dprotaso

Copy link
Copy Markdown
Member Author

/assign @dsimansk @evankanderson

@codecov

codecov Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.29%. Comparing base (7eea605) to head (a124960).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16765      +/-   ##
==========================================
- Coverage   80.32%   80.29%   -0.04%     
==========================================
  Files         217      217              
  Lines       13701    13701              
==========================================
- Hits        11006    11001       -5     
- Misses       2327     2329       +2     
- Partials      368      371       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evankanderson evankanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2026
@knative-prow
knative-prow Bot merged commit bd5953c into knative:main Nov 12, 2026
67 checks passed
@dprotaso
dprotaso deleted the reduce-mesh-diagnostic-streams branch November 13, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants