Skip to content

feat: add custom image and build template OpenAPIs - #4922

Merged
leozhang2018 merged 6 commits into
koderover:mainfrom
huanghongbo-hhb:feat/custom-image-build-template-openapi
Aug 25, 2026
Merged

feat: add custom image and build template OpenAPIs#4922
leozhang2018 merged 6 commits into
koderover:mainfrom
huanghongbo-hhb:feat/custom-image-build-template-openapi

Conversation

@huanghongbo-hhb

@huanghongbo-hhb huanghongbo-hhb commented Aug 20, 2026 •
edited by landylee007
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Add OpenAPIs for managing custom images and build templates.

Main Changes

  • Add CRUD endpoints with existing system and template permissions.
  • Preserve existing build defaults, VM labels, Dockerfile modes, parameters, and advanced settings.
  • Block image deletion for active build, template, test, and scan references.
  • Make build template pagination deterministic by name and ID.

Risk / Compatibility

  • Existing API contracts remain unchanged; shared template list ordering and image reference checks become stricter.

Test

  • go test -vet=off ./pkg/microservice/aslan/core/common/repository/mongodb/... ./pkg/microservice/aslan/core/system/... ./pkg/microservice/aslan/core/templatestore/... ./pkg/tool/openapi ./pkg/types

Contact

Contact: huanghongbo@koderover.com

This change is Reviewable

@huanghongbo-hhb
feat: add custom image and build template OpenAPIs
20ccec0 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
fix: return not found for missing OpenAPI resources
940cd52 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
refactor: reuse existing image and build template services
b274a2b 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@github-actions github-actions Bot removed the common label Aug 21, 2026
@huanghongbo-hhb
refactor: remove redundant OpenAPI service wrappers
afad9bc 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@huanghongbo-hhb
refactor: preserve existing custom image deletion behavior
80f10a0 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
PetrusZ
PetrusZ reviewed Aug 25, 2026
View reviewed changes
Comment thread pkg/microservice/aslan/core/templatestore/service/openapi_build.go Outdated
Comment thread pkg/microservice/aslan/core/templatestore/handler/router.go Outdated
Comment thread pkg/microservice/aslan/core/system/service/basic_images.go Outdated
Comment thread pkg/microservice/aslan/core/system/service/basic_images.go Outdated
Comment thread pkg/microservice/aslan/core/common/repository/mongodb/build_template.go Outdated
Comment thread pkg/microservice/aslan/core/common/repository/mongodb/scanning.go Outdated
Comment thread pkg/microservice/aslan/core/common/repository/mongodb/scanning_template.go Outdated
@huanghongbo-hhb
refactor: address build template openapi review
ce29c08 
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
@leozhang2018
leozhang2018 merged commit 8986cb2 into koderover:main Aug 25, 2026
4 checks passed
@huanghongbo-hhb huanghongbo-hhb mentioned this pull request Aug 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetrusZ PetrusZ PetrusZ approved these changes
+1 more reviewer
@Cynthia-0203 Cynthia-0203 Cynthia-0203 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

service/aslan

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@huanghongbo-hhb @PetrusZ @Cynthia-0203 @leozhang2018