fix: bound MemWAL merge memory with ROLLOUT_MERGE_MAX_BYTES - #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemWAL generations have variable sizes, so limiting a merge to a fixed generation count can still buffer several GiB of inline blobs. Add
ROLLOUT_MERGE_MAX_BYTES/--rollout-merge-max-bytes, defaulting to 1 GiB, alongside the existing generation cap.get_array_memory_size()before deduplication, and stop after the generation that reaches the byte budget. Either cap ends the pass; remaining generations stay pending for subsequent passes.0disables only that cap. Document the defaults and generation-boundary behavior.Testing
cargo test -p lance-context-core -p lance-context-server --all-targets— 306 passed, 0 failed, 3 existing tests ignored; includes all 8 WAL merge cleanup regression tests.cargo clippy --workspace --all-targets -- -D warnings— passed.cargo clippy --manifest-path crates/lance-context/Cargo.toml --all-targets -- -D warnings— passed.cargo fmt --all -- --check— passed.