feat: enable the fragment reuse index on stable row id datasets - #9120
Draft
brendanclement wants to merge 3 commits into
Conversation
github-actions
Bot
added
A-python
brendanclement
force-pushed
the
brendanclement/oss-2189-enable-fragment-reuse-index-even-when-srid-is-enabled
branch
from
September 10, 2026 05:18
6b5f3f0 to
ec31dd7
Compare
…d tables Reserve reader/writer feature flag 1 << 9 for a table version that uses stable row ids and carries a fragment reuse index. The index records how physical row addresses moved; entries of an index that stores stable row ids must not be remapped through it, so builds without domain-aware index loading must refuse such a table. This build defines the bit but does not support it yet; support lands with the implementation. Part of lance-format#8977
On a stable-row-id dataset most indices store stable row ids, which a fragment reuse index must not remap: stable ids start at 0 and collide with fragment 0's row addresses. Index loading, merging and building now hand the fragment reuse index only to indices that store row addresses. Cleanup and remap_column_index treat stable-id indices as needing only their fragment coverage repaired, and the manifest build derives the FLAG_FRAG_REUSE_WITH_STABLE_ROW_IDS compatibility flag, which this build now supports. A JSON index answers in its target's domain; both domain predicates now follow the target, and malformed JSON details are an error rather than a guess. Under stable row ids the rewrite branch no longer recalculates the fragment reuse index's own coverage, which the eager path never touched.
Compaction with defer_index_remap no longer rejects stable row ids. The row addresses the fragment reuse index records are derived from the fragment metadata (every physical row minus the deletion vector), which is what the scan yields without stable row ids, while the row id sequences are rechunked as before. Closes lance-format#8977
brendanclement
force-pushed
the
brendanclement/oss-2189-enable-fragment-reuse-index-even-when-srid-is-enabled
branch
from
September 10, 2026 17:05
ec31dd7 to
1b17fdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8977
Depends on #9119.