docs(linalg): document the argmin/argmax optional-value kernels - #9124
Open
fightBoxing wants to merge 1 commit into
Open
fightBoxing wants to merge 1 commit into
fightBoxing wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The rustdoc matches the kernels’ actual boundary behavior, including skipped None values, strict comparisons against the numeric bounds, zip truncation, and biased selection returning the original unbiased value. This is the smallest appropriate change for the documentation gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lance-linalgthat lacked rustdoc:argmax_opt,argmin_value_opt, andargmin_value_float_with_bias.argmin_value_float_with_bias: the comparison usesvalue + biasbut the returned value is the original value without the bias term; passingNoneforbiasfalls back toargmin_value_float.Validation
cargo test -p lance-linalgcargo doc -p lance-linalg --no-depscargo fmt --allcargo clippy -p lance-linalg --tests -- -D warnings