feat(format): declare replaced offsets on DataReplacement - #9138
Draft
wkalt wants to merge 1 commit into
Draft
Conversation
A column replacement rewrites a fragment's whole column file even when only some rows changed, so last_updated_at_version moves on every row of the fragment and an incremental consumer re-reads rows whose values did not change. Update already carries updated_fragment_offset_bitmaps for the same reason; DataReplacement has no equivalent. This adds replaced_offset_bitmaps to DataReplacement: per replaced fragment, the physical offsets whose values changed, as portable RoaringBitmap bytes. Present, only those offsets take the new version and the rest keep theirs; absent, or on a fragment with no sequence to keep, every row does, which is what every existing writer produced. The field is additive. Spec-only per the format change process: proto, transaction.md, and the conversion edits needed to compile. The stamping and validation follow in a separate PR.
github-actions
Bot
added
A-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A column replacement rewrites a fragment's whole column file even when only some rows changed, so
last_updated_at_versionmoves on every row of the fragment and an incremental consumer re-reads rows whose values did not change.Updatealready carriesupdated_fragment_offset_bitmapsfor the same reason;DataReplacementhas no equivalent.This adds
replaced_offset_bitmapstoDataReplacement: per replaced fragment, the physical offsets whose values changed, as portable RoaringBitmap bytes. Present, only those offsets take the new version and the rest keep theirs; absent, or on a fragment with no sequence to keep, every row does, which is what every existing writer produced. Keys must name replaced fragments and offsets must be below the fragment's physical row count; anything else is rejected as invalid. The field is additive: absent decodes as a full stamp and older readers ignore it.Spec-only per the format change process: proto,
transaction.md, and the conversion edits needed to compile. The stamping and validation follow in a separate PR.