Unify FAQ preview links with boxed accordion rows - #3967
Draft
marcklingen wants to merge 2 commits into
Draft
marcklingen wants to merge 2 commits into
marcklingen wants to merge 2 commits into
Conversation
FAQ link previews now use the same bordered row chrome as accordion items, with a trailing arrow and new-tab navigation. The ask CTA shares that box on both accordion and preview pages. Co-authored-by: Marc Klingen <marcklingen@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Resolve FaqAsk.tsx against the merged full-box click change by keeping the shared boxed ask row (full-card hit target) instead of the old linked underline styling. Co-authored-by: Marc Klingen <marcklingen@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FAQ preview links (items that navigate to another FAQ page) used a blue underlined bullet list, while accordion FAQs used stacked bordered boxes with a trailing
+. This makes the two surfaces share one row shell.What changed
FaqRow/faqRowClassfor the bordered card chrome used by accordion rows, preview links, and the ask CTA.+, and open the target in a new tab (target="_blank"+rel="noopener noreferrer").+/-.FaqPreviewnow renders boxed rows (the old bullet-list path is gone). ExistingrenderAsRowsprops still compile.Files
components/faq/FaqRow.tsx(new)components/Details.tsxcomponents/faq/FaqAsk.tsxcomponents/faq/FaqPreview.tsxlib/markdown-component-renderers.jsMarketing
FAQAccordionis unchanged (different stackedborder-tchrome).Verified locally
/docs/compatibility— accordion rows with+and shared ask box/docs/prompt-management/troubleshooting-and-faq— boxed preview rows with arrows; click opens/faq/all/...in a new tab