Skip to content

Fix building docs - #479

Merged
simo5 merged 1 commit into
latchset:mainfrom
Jakuje:docs-fix
Jul 20, 2026
Merged

simo5 merged 1 commit into
latchset:mainfrom
Jakuje:docs-fix

Conversation

@Jakuje

@Jakuje Jakuje commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description

This was accidentally removed in 0a96cb5

Checklist

  • This is not a code change

Reviewer's checklist:

  • Any issues marked for closing are fully addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • A changelog entry is added if the change is significant
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible text
  • Doc string are properly updated

Signed-off-by: Jakub Jelen <jjelen@redhat.com>
@Jakuje
Jakuje requested a review from simo5 July 8, 2026 16:32
@simo5

simo5 commented Jul 8, 2026

Copy link
Copy Markdown
Member

Actually using openssl-sys may allow us to enable docs building for crates.io as well, so far it did not work because I did not have a way to guarantee openssl was available, but they have a specific exception for openssl-sys IIRC.
Do you want to tackle enabling that as well ?
See #442 for context

@Jakuje

Jakuje commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

I agree that would be good to have a generic solution, but this is just a bandaid and fixup of what I messed (and missed) in 0a96cb5 where I removed this block as no longer needed by changing default to openssl-sys, but did not add it back when we reverted.

This is currently preventing the docs of latest release to build: https://docs.rs/crate/ossl/latest

@simo5 simo5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5
simo5 merged commit 09fda28 into latchset:main Jul 20, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants