Repository navigation
fix(release-autopilot): per-repo gating, Automations page links, plugin install step (EMSR-2676, EMSR-2650, EMSR-2634) - #245
Open
fsaresh wants to merge 8 commits into
Conversation
…in install step (EMSR-2676, EMSR-2650, EMSR-2634)
- Onboarding and settings skills: each repo's own settings decide what
runs in it. Accounts on the project Automations page do not read the
account settings; other accounts still do until the migration runs, so
the account tools and write stay. Repo writes now turn on each picked
capability, and PR diagnosis reads the repo's effective setting and
enabledOverride.
- Bring your own key, auto-cleanup, and auto-archival link to
/projects/{projectKey}/settings/automations, with the old pages as the
fallback when the Automations page is missing.
- Onboarding prerequisites and README: install the LaunchDarkly plugin
first.
- Evals: Automations links, repo mapping turns auto-flagging on, and unit
tests for those assertions.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Generated-by: termag
Skill eval results
Only suites whose source actually changed since their last recorded score were re-run. Soft-failing while we stabilise the baseline. |
Contributor
sarahlessner
approved these changes
Nov 5, 2026
Contributor
|
@fsaresh I can take this over and clean this up unless your agent is just doing it |
Contributor
Author
|
@sarahlessner Go for it, all yours -- was about to message you on slack saying about the same |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…the automations tool names
…o does not set, and fix the repo-override fixture
… capability only once the account setting is on
…al settings skills
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| ## Core Principles | ||
|
|
||
| 1. **Confirm before every write.** State the current and proposed values, wait for a yes that names the change in this turn, then write. A yes from an earlier turn, or a vague "go ahead", is not enough. | ||
| 2. **Only a person can turn it on.** Turning archival on requires confirming its risk on the Automations page. Never claim you turned it on. |
Contributor
There was a problem hiding this comment.
@twahlfeld-dev could you check the new auto-archival skill? It uses the MCP tools from launchdarkly/mcp#462. Please check these against how archival actually works:
- A person turns archival on, and the agent only links to the Automations page.
- Flags with no maintainer are never archived (from the
notifyMemberIdsAPI docs). - The "why wasn't my flag archived" checklist: off, no maintainer, not ready or still in the grace period, waiting on approval, run limit reached.
- Flags archived this way get the
auto-archivedtag.
…ted browser steps, and use search-members
…0-2634-onboarding-skill # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 44d59a8. Configure here.
…ng a cause; diagnosis eval accepts the unmapped-repo answer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Release Autopilot onboarding and settings skills are wrong in three places:
enable-automations-settingson, gonfalon reads only each repo's own row (resolve_repo_settings.go), and a capability the repo does not set is off. A repo that onboarding maps comes back with auto-flagging off, and PR diagnosis stops at the account setting and gives the wrong cause./projects/{key}/settings/vegaand/settings/lifecycle. With the Automations page on, those sections are on/projects/{key}/settings/automations(projects.$projectKey.settings.automations.tsx).Fix
{ "enabled": true }for each picked capability. The settings skill sends both capabilities on a new mapping. PR diagnosis reads the repo's effectiveenabledandenabledOverride. Before, it readenabledOverride: trueas "opted out", but that field holds the repo's stored value./projects/{projectKey}/settings/automations, in the Inference, Automated flag cleanup, and Automatic archival sections. The reference files keep the old pages as the fallback for accounts where the link opens the general project settings page instead.enabledOverride: falsefor a repo that turns the capability off.skills.jsonis regenerated and CHANGELOG is updated. The plugin versions do not change.Testing
python3 scripts/validate_skills.py: 54 skills valid.python3 -m unittest tests/test_*.py: OK.cd evals && npm test: 157 pass. The newtests/release-autopilot-onboarding-assertions.test.jscovers the Automations-link assertions andrepoTurnsAutoFlaggingOn.eval-skillsCI job runs it.Related
get-automations/update-automations/delete-automations-repo-settings, and the older names stay only in the fallback note for servers that have not picked up the rename._notein gram-functions (releaseautopilotsettings.ts) still says "Account settings are the master gate". That text is outside this repo.🤖 Generated with Claude Code
Opened from termag
Link to Devin session: https://app.devin.ai/sessions/b392772a83b5402b9cc688095c66d6c9
Open in Devin Desktop: https://app.devin.ai/desktop/session/b392772a83b5402b9cc688095c66d6c9?variant=devin
Requested by: @sarahlessner
Note
Overview
Adds two experimental agent skills for Automations auto-cleanup and auto-archival (MCP
get/update-automations-cleanupandget/update-automations-archival), registers them in the Claude/Cursor plugins, and documents them in the README and CHANGELOG.Release Autopilot onboarding (0.4.0) and settings (1.5.0) now treat each repo’s mapping as the source of truth on accounts with the project Automations page: repo writes explicitly turn on picked capabilities; PR diagnosis checks mapping and effective repo auto-flagging first (including
enabledOverride), not “account gate off” alone. Browser guidance for bring-your-own-key, cleanup, and archival points at/projects/{key}/settings/automations, with lifecycle/vega as fallbacks. Onboarding prerequisites tell users to install the LaunchDarkly plugin first.Evals gain
repoTurnsAutoFlaggingOn, Automations-link assertions (replacing lifecycle/vega checks), an updated repo-override mock, and a small unit test file for those assertions.Reviewed by Cursor Bugbot for commit 6164d69. Bugbot is set up for automated code reviews on this repo. Configure here.
Related Jira issue: EMSR-2676: [Claude] Release Autopilot onboarding skill sends users to old /settings/lifecycle and /settings/vega pages instead of Automations