[keelerm84]

Summary

valueForAll replaced the variations with the single value and called variationForAll 0, but left the off variation unchanged. A new test flag is a boolean flag with off variation 1, so the built flag had one variation and an off variation of 1. When targeting was off, the off variation was out of range and the flag returned the default value instead of the value. The function is documented to return the value whether targeting is on or off.

valueForAll now also sets the off variation to 0. variationForAll is unchanged. A new test turns targeting off after valueForAll and checks that the flag evaluates to the value. valueForAllUsers is an alias, so it gets the fix too.

This matches the fix in launchdarkly/ruby-server-sdk#489.

_{Opened from termag}

---

Note

Overview
valueForAll in the TestData flag builder now sets off variation to index 0 in addition to a single variation and fallthrough, so evaluation matches its documented behavior when targeting is off.

Previously, shrinking the flag to one variation left the default boolean off variation at index 1, which was invalid and caused the SDK to return the client default instead of the configured value.

A new integration test applies valueForAll then on False and asserts the flag still returns the configured string value.

^{Reviewed by Cursor Bugbot for commit 9f987d4. Bugbot is set up for automated code reviews on this repo. Configure here.}