[keelerm84]

Summary

TestData.FlagBuilder.valueForAll replaced the flag's variations with the single value and then called variationForAll(0). That set the fallthrough to 0 but left the off variation unchanged. A new test flag is a boolean flag with off variation 1, so the built flag had variations: [value] and offVariation: 1. The index was out of range, and the flag failed to evaluate (malformed flag) when targeting was off. The method's documentation says it returns the value regardless of whether targeting is on or off.

valueForAll now also sets the off variation to 0. variationForAll is unchanged. The new tests check the built flag with targeting on and off, and check that a client evaluates the flag to the value when targeting is off.

This matches the Ruby fix in launchdarkly/ruby-server-sdk#489.

_{Opened from termag}

---

Note

Overview
Fixes TestData.FlagBuilder.valueForAll so flags evaluate correctly when targeting is off. After collapsing variations to a single value, the builder only set fallthrough via variationForAll(0), leaving the default boolean off variation index 1—invalid for one variation and causing malformed-flag evaluation instead of returning the configured value.

valueForAll now also calls offVariation(0), matching documented behavior (same value on or off). variationForAll is unchanged. New unit and client tests cover the built flag shape and off-targeting evaluation.

^{Reviewed by Cursor Bugbot for commit 0a798d5. Bugbot is set up for automated code reviews on this repo. Configure here.}