Skip to content

chore: Consolidate browser SDK examples into a single examples directory - #2178

Draft
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-3457/refactor-browser-examples
Draft

joker23 wants to merge 1 commit into
mainfrom
skz/sdk-3457/refactor-browser-examples

Conversation

@joker23

@joker23 joker23 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Moves the browser SDK example apps into one examples/ directory, so the layout matches the other packages in this repository (react, vue, electron, node-client, server-ai, openfeature).

New layout under packages/sdk/browser/examples/:

Path Was Workspace name
README.md (new) Index of the examples
getting-started/ example/ @launchdarkly/js-client-sdk-example-getting-started
features/data-saving-mode/ example-fdv2/ @launchdarkly/js-client-sdk-example-data-saving-mode
features/custom-eventsource/ (unchanged path) @launchdarkly/js-client-sdk-example-custom-eventsource

Other changes:

  • The workspaces now use the js-client-sdk-example-* naming, to match the react and vue examples (for example @launchdarkly/react-sdk-example-data-saving-mode).
  • The data saving mode example gets a new README that describes what it demonstrates and carries the EAP note. The "temporary app" comment is removed.
  • Root package.json workspaces, the homepage fields, and the custom EventSource README use the new paths and names.
  • release-please-config.json extra-files for packages/sdk/browser point at the new example package.json paths, so the release PR continues to bump the @launchdarkly/js-client-sdk pin in each example.
  • browser.yml and browser-nightly.yaml use the new workspace names.

After this merges, the next chore: release main PR must bump @launchdarkly/js-client-sdk in all three example package.json files.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 32490 bytes
Compressed size limit: 32500
Uncompressed size: 153198 bytes

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 34510 bytes
Compressed size limit: 35000
Uncompressed size: 123185 bytes

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26066 bytes
Compressed size limit: 44000
Uncompressed size: 168326 bytes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant