Repository navigation
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
Author
|
this PR will be superceded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-adds comments to the built binary of the common client repo. The reason for this is that the inherited comments in the JSDocs are from the built resources. When we stripped the comments to make our resource size look better, we also removed all of the inherited documentation in our JSDocs.
This PR also removes the size limit check for the common client sdk as most of the bulk will be from comments. This should be fine as we are mostly concerned with the
js-client-sdksize.Note
Overview
Fixes lost inherited JSDoc in
@launchdarkly/js-client-sdk-commontype declarations by stopping TypeScript’sremoveCommentsoption during Rollup builds, since that was stripping comments from.d.tsfiles as well as JS.Comment removal for runtime bundles (
dist/esm/index.mjsanddist/cjs/index.cjs) now runs through a@rollup/plugin-terserstep configured to drop comments only (no compress/mangle, beautified output), applied after the existing TypeScript/commonjs/resolve/json plugins for both ESM and CJS targets.Reviewed by Cursor Bugbot for commit a9d9d7e. Bugbot is set up for automated code reviews on this repo. Configure here.