Repository navigation
fix: prevent the react sdk fetch-eventsource type declarations from being deleted during the build - #2180
Open
joker23 wants to merge 1 commit into
Open
fix: prevent the react sdk fetch-eventsource type declarations from being deleted during the build#2180joker23 wants to merge 1 commit into
joker23 wants to merge 1 commit into
Conversation
being deleted during the build
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will make it so that the react sdk build will not cannibalize itself due to having multiple bundle builds that declare
clean.Instead, we will manually clean the dist directory before running the full build.
Note
Overview
Fixes a build race where parallel
tsupconfigs could delete each other’s output indist, which could leave./fetch-eventsourcetype declarations missing after a build.The
buildscript now runsrm -rf distbeforetsup, andcleanis removed from all tsup configs (with a comment explaining that a config withclean: truecan wipe declaration files while other entry builds are still running).Reviewed by Cursor Bugbot for commit c7a2dff. Bugbot is set up for automated code reviews on this repo. Configure here.