Skip to content

fix: prevent the react sdk fetch-eventsource type declarations from being deleted during the build - #2180

Open
joker23 wants to merge 1 commit into
mainfrom
skz/react-sdk-tsup-dts-clean-race
Open

joker23 wants to merge 1 commit into
mainfrom
skz/react-sdk-tsup-dts-clean-race

Conversation

@joker23

@joker23 joker23 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

This PR will make it so that the react sdk build will not cannibalize itself due to having multiple bundle builds that declare clean.

Instead, we will manually clean the dist directory before running the full build.


Devin Review


Note

Overview
Fixes a build race where parallel tsup configs could delete each other’s output in dist, which could leave ./fetch-eventsource type declarations missing after a build.

The build script now runs rm -rf dist before tsup, and clean is removed from all tsup configs (with a comment explaining that a config with clean: true can wipe declaration files while other entry builds are still running).

Reviewed by Cursor Bugbot for commit c7a2dff. Bugbot is set up for automated code reviews on this repo. Configure here.

@joker23
joker23 requested a review from a team as a code owner November 5, 2026 21:38
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 32490 bytes
Compressed size limit: 32500
Uncompressed size: 153198 bytes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 34510 bytes
Compressed size limit: 35000
Uncompressed size: 123185 bytes

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26066 bytes
Compressed size limit: 44000
Uncompressed size: 168326 bytes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant