Repository navigation
Use structured logging for MTC components - #9152
Open
aarongable wants to merge 4 commits into
Open
aarongable wants to merge 4 commits into
aarongable wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland the blog package, which has all of the scaffolding and infrastructure for outputting structured logs. This is a partial reland of PR #8606, which was merged as commit abfceb5. It is therefore also a partial revert of PR #8853, which was merged as commit 4f9cc84.
Add a stub to cmd/shell.go which creates a structured logger. This stub will eventually grow to replace the existing cmd.NewLogger, when we're ready to use structured logging for all shared tasks (cmd.AuditPanic, the mysql logger, etc).
Plumb the new structured logger through the MTCA, MTCB, and MTPublisher packages, and update their logging calls to take advantage of it.
Part of #8557
Fixes #9149
Note
For reviewers, the first commit is pulled directly from #8854 with no changes. The second and third commits build on that to use slog within the MTC packages.
Example logs: