pw: retry on 502 and 504 errors#82
Merged
Merged
Conversation
Recently, some services have failed due to a 504 error from Patchwork when retrieving a JSON with: self._request(...).json() or: self._get(...).json() In both cases, the logs were showing: **** Response <Response [504]> **** Response data <html> <head><title>504 Gateway Time-out</title></head> <body> <center><h1>504 Gateway Time-out</h1></center> </body> </html> Ask the requests lib to retry on 502 and 504 for us, that seems the easiest (if this works as expected). Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, some services have failed due to a 504 error from Patchwork when retrieving a JSON with:
or:
In both cases, the logs were showing:
Ask the requests lib to retry on 502 and 504 for us, that seems the easiest (if this works as expected).