logger: rotate log at startup#83
Merged
Merged
Conversation
Before this modification, the log files were truncated at startup: the last log messages were then lost in case of restart, e.g. a service failed, restarted because the crashed seemed to be caused by a transient error, then ... arf, too late to understand why. Now, the log files, if any and not empty, are rotated at startup. Another solution could be to modify _log_open_init() to open the log files with 'a+' to avoid the truncation. It seems cleaner to do a rotation. The drawback is that it can create many small files in case of frequent restarts, but that shouldn't be that frequent. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this modification, the log files were truncated at startup: the last log messages were then lost in case of restart, e.g. a service failed, restarted because the crashed seemed to be caused by a transient error, then ... arf, too late to understand why.
Now, the log files, if any and not empty, are rotated at startup. Another solution could be to modify _log_open_init() to open the log files with 'a+' to avoid the truncation. It seems cleaner to do a rotation. The drawback is that it can create many small files in case of frequent restarts, but that shouldn't be that frequent.