logger: org: log time and delta at section start/end#84
Closed
matttbe wants to merge 2 commits into
Closed
Conversation
It seems interesting to log the time when starting and ending a section to know how long an action took Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
It is clearer than having to deal with full time. Signed-off-by: Matthieu Baerts <matttbe@kernel.org>
Contributor
|
I don't think the timestamping belongs in the org format? Commands print the duration by themselves IIRC. If the HTTP requests need timing they should also print? |
Member
Author
|
Sure, I can add it only for the HTTP one. I was thinking doing that in the org format could be helpful for other modules, but maybe not :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the time in the logs looks valuable, e.g. to check how long an HTTP request took.