fix(airplane): use T8 font size and add 12px left padding for tips label - #587
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider replacing the hardcoded
leftPadding: 12with a shared spacing/metrics constant (if available in the design system) to keep spacing consistent and centrally managed. - If there is a standard way to set text styles (e.g., using a predefined text role or style instead of directly binding
font.pixelSize), aligning with that convention would make the styling more consistent with other labels.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider replacing the hardcoded `leftPadding: 12` with a shared spacing/metrics constant (if available in the design system) to keep spacing consistent and centrally managed.
- If there is a standard way to set text styles (e.g., using a predefined text role or style instead of directly binding `font.pixelSize`), aligning with that convention would make the styling more consistent with other labels.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
55bf299 to
0ffaad2
Compare
修复飞行模式页面提示文字的字号和左边距问题: - 将提示文字字号从默认大小改为 T8(D.DTK.fontManager.t8.pixelSize) - 添加 12px 左边距(leftPadding: 12),使文字左侧与列表左侧对齐 Log: bug-371531
0ffaad2 to
0f850ad
Compare
…2024-2026 修复 SPDX 版权头年份范围,结束年份应反映最新修改时间 2026, 且横杠两侧不应有空格。
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 --- a/dcc-network/qml/PageAirplane.qml
+++ b/dcc-network/qml/PageAirplane.qml
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2024 - 2027 UnionTech Software Technology Co., Ltd.
+// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later
import QtQuick 2.15
import QtQuick.Controls 2.15
@@ -64,6 +64,8 @@ DccObject {
page: D.Label {
text: dccObj.displayName
wrapMode: Text.WordWrap
+ font.pixelSize: D.DTK.fontManager.t8.pixelSize
+ leftPadding: 12
}
}
} |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, iCancely The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Issue
The airplane mode tips label uses a default font size that is too large, and has no left padding, causing misalignment with list items below.
Changes
Log: Fix airplane mode tips label font size and left padding
Influence: Airplane tips text aligns with list items
问题
飞行模式页面提示文字字号偏大,且没有左边距,与下方列表项未对齐。
修改
Log: 修复飞行模式页面提示文字字号和左边距问题
PMS: BUG-371531
Influence: 飞行模式提示文字与列表项对齐