Repository navigation
test: add DevicePixel pageRect regression tests for BUG-380145 - #681
Merged
pengfeixx merged 1 commit intoOct 22, 2026
Merged
Conversation
Add regression tests verifying pageRect(DevicePixel) unit consistency with device-pixel margins across all three print paths (doPrint, doPrintWithLargeDoc, asynPrint), preventing negative titleBox width under Qt6 where pageRect(Point) no longer matches native DPI. Log: Added GTest cases for DevicePixel pageRect fix in print paths. Influence: None — test-only change, no production code modified. PMS: BUG-380145
pengfeixx
marked this pull request as draft
October 21, 2026 14:47
Reviewer's GuideAdds test-only GTest coverage for BUG-380145, using high-resolution PDF and image-backed printers to verify DevicePixel pageRect dimensions remain consistent with device-pixel margins and prevent negative title-box widths in doPrint, doPrintWithLargeDoc, and asynPrint. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
pengfeixx
marked this pull request as ready for review
October 22, 2026 05:39
lzwind
approved these changes
Oct 22, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: add DevicePixel pageRect regression tests for BUG-380145
Add regression tests verifying pageRect(DevicePixel) unit consistency
with device-pixel margins across all three print paths (doPrint,
doPrintWithLargeDoc, asynPrint), preventing negative titleBox width
under Qt6 where pageRect(Point) no longer matches native DPI.
Log: Added GTest cases for DevicePixel pageRect fix in print paths.
Influence: None — test-only change, no production code modified.
PMS: BUG-380145
Summary by Sourcery
Tests: