Skip to content

test: add DevicePixel pageRect regression tests for BUG-380145 - #681

Merged
pengfeixx merged 1 commit into
linuxdeepin:masterfrom
pengfeixx:ut-supplement/deepin-editor-20261021
Oct 22, 2026
Merged

pengfeixx merged 1 commit into
linuxdeepin:masterfrom
pengfeixx:ut-supplement/deepin-editor-20261021

Conversation

@pengfeixx

@pengfeixx pengfeixx commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

test: add DevicePixel pageRect regression tests for BUG-380145

Add regression tests verifying pageRect(DevicePixel) unit consistency
with device-pixel margins across all three print paths (doPrint,
doPrintWithLargeDoc, asynPrint), preventing negative titleBox width
under Qt6 where pageRect(Point) no longer matches native DPI.

Log: Added GTest cases for DevicePixel pageRect fix in print paths.
Influence: None — test-only change, no production code modified.
PMS: BUG-380145

Summary by Sourcery

Tests:

  • Add regression coverage for consistent DevicePixel page rectangles and margin calculations across synchronous, large-document, and asynchronous print paths.

Add regression tests verifying pageRect(DevicePixel) unit consistency
with device-pixel margins across all three print paths (doPrint,
doPrintWithLargeDoc, asynPrint), preventing negative titleBox width
under Qt6 where pageRect(Point) no longer matches native DPI.

Log: Added GTest cases for DevicePixel pageRect fix in print paths.
Influence: None — test-only change, no production code modified.
PMS: BUG-380145
@pengfeixx
pengfeixx marked this pull request as draft October 21, 2026 14:47
@sourcery-ai

sourcery-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Reviewer's Guide

Adds test-only GTest coverage for BUG-380145, using high-resolution PDF and image-backed printers to verify DevicePixel pageRect dimensions remain consistent with device-pixel margins and prevent negative title-box widths in doPrint, doPrintWithLargeDoc, and asynPrint.

File-Level Changes

Change Details Files
Added regression coverage for DevicePixel pageRect and device-pixel margin consistency across all print execution paths.
  • Exercises the standard doPrint path using a high-resolution PDF printer and verifies the print layout completes.
  • Exercises the large-document print path with a populated print-document list and verifies processing completes.
  • Exercises asynchronous printing with an image-backed painter and verifies rendering modifies the output.
  • Checks that DevicePixel dimensions produce positive title-box width while the legacy Point dimensions reproduce the regression condition.
  • Validates DevicePixel-to-Point sizing against the printer DPI in the asynchronous path.
tests/widgets_ut/test_window.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@pengfeixx
pengfeixx marked this pull request as ready for review October 22, 2026 05:39
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx
pengfeixx merged commit 3273183 into linuxdeepin:master Oct 22, 2026
16 of 17 checks passed
@pengfeixx
pengfeixx deleted the ut-supplement/deepin-editor-20261021 branch October 22, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants