Repository navigation
TEL-1120 Adding provider info to InternalCreateSIPParticipantRequest - #1850
Open
genseric-ghiro wants to merge 5 commits into
Open
genseric-ghiro wants to merge 5 commits into
genseric-ghiro wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 701383c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nishadmusthafa
approved these changes
Oct 15, 2026
| // URIUser returns the user part of a sip, sips or tel URI, with the display | ||
| // name, angle brackets, host and parameters removed. A URI with no user part | ||
| // and anything that is not a URI returns an empty string. | ||
| func URIUser(uri string) string { |
Contributor
There was a problem hiding this comment.
we don't need to address this now. But I feel like there's similar code in other places like
protocol/livekit/sip_validation.go
Lines 314 to 337 in 4ebc7a9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary