Repository navigation
fix(bank-accounts): show the server's reason for BANK_ACCOUNT_INVALID - #730
Merged
Merged
Conversation
The backend sends an allowlisted, customer-safe reason with this code
("Bank is not supported.", "This account number cannot be used...").
The app replaced it with the generic "Some of these details aren't
valid" line, so a customer could not tell which detail to fix. Seen on
the Max during TEST device testing.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
On an iPhone 13 Pro Max the number-pad covered the last field and the button. Use KeyboardAwareScrollView (already in the tree) with extra scroll height and bottom padding. The screen spec overrides the repo-wide null mock so the form still renders, and its BANK_ACCOUNT_INVALID / INVALID_INPUT rows now expect the server's message per the mapper change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during device testing on TEST. Adding an account whose number already exists elsewhere returned
BANK_ACCOUNT_INVALIDwith the server's reason ("This account number cannot be used. Please contact support if it is yours."), and the app showed only "Some of these details aren't valid. Check them and try again." so the customer could not tell what to fix.The mapper now prefers the server message for
BANK_ACCOUNT_INVALID/INVALID_INPUT(these are allowlisted, customer-safe strings on the backend as of lnflash/flash#514) and keeps the generic line only when the message is empty. New spec covers the four branches of the mapper.🤖 Generated with Claude Code