Repository navigation
feat: safely export custom configurations without overwriting files - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Saving a custom configuration with shell redirection can truncate an existing file before the generator rejects an invalid group. Add
--output PATHto create a new file exclusively after validation, supporting preset, custom-group and interactive modes. Existing files and symlink targets remain untouched, and prompts/status stay on stderr.Interactive EOF previously exited successfully without producing a configuration. It now reports failure; blank Enter still selects the recommended preset and Ctrl+C cancels with exit status 130. Update the README, setup examples, maintenance notes and changelog to explain safe exports.
Source and testing
git diff --checkpasses. No Quantumult X/iOS device testing: this change affects the desktop generator; app configuration contents are unchanged.Checklist